Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: migrate to Criterion benchmark #240

Closed
wants to merge 5 commits into from
Closed

Feat: migrate to Criterion benchmark #240

wants to merge 5 commits into from

Conversation

0xethsign
Copy link
Member

@0xethsign 0xethsign commented Mar 30, 2021

Fixes #233

@0xethsign 0xethsign changed the title migrate to Criterion benchmark Feat: migrate to Criterion benchmark Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #240 (0f664ce) into master (1be8610) will decrease coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 0f664ce differs from pull request most recent head 6b7adad. Consider uploading reports for the commit 6b7adad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   80.25%   79.99%   -0.27%     
==========================================
  Files          22       22              
  Lines        3429     3429              
==========================================
- Hits         2752     2743       -9     
- Misses        677      686       +9     
Impacted Files Coverage Δ
src/effector.rs 74.54% <0.00%> (-3.64%) ⬇️
src/model/default_model.rs 92.58% <0.00%> (-0.90%) ⬇️
src/config.rs 86.33% <0.00%> (-0.63%) ⬇️
src/enforcer.rs 85.54% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be8610...6b7adad. Read the comment docs.

@0xethsign
Copy link
Member Author

Please review this @hackerchai @hsluoyz
There is some problem with the github actions support, which I'm working on. Are there any changes required apart from that?

@hsluoyz
Copy link
Member

hsluoyz commented Mar 30, 2021

@hackerchai

@hackerchai
Copy link
Member

@smrpn lgtm

@hsluoyz
Copy link
Member

hsluoyz commented Mar 31, 2021

@smrpn plz fix all failed checks:

image

@0xethsign
Copy link
Member Author

@smrpn plz fix all failed checks:

image

on it.

@0xethsign 0xethsign closed this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Criterion benchmark
3 participants