Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Criterion benchmark #233

Open
hackerchai opened this issue Mar 13, 2021 · 2 comments
Open

Migrate to Criterion benchmark #233

hackerchai opened this issue Mar 13, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@hackerchai
Copy link
Member

https://github.com/bheisler/criterion.rs
More and more rust projects start to use criterion as the default benchark library for more specific performence statistics

@hackerchai hackerchai added enhancement New feature or request help wanted Extra attention is needed labels Mar 13, 2021
@0xethsign
Copy link
Member

0xethsign commented Apr 8, 2021

The github actions for the current benchmark tool libtest runs only on the nightly toolchain.
The github actions for criterion.rs, https://github.com/boa-dev/criterion-compare-action/tree/move_to_actions runs only on the stable toolchain.
Before migrating to criterion, the previous benchmark tool needs to be removed, because builds are failing while comparing the last bench reports.

git checkout master
Previous HEAD position was 5f8f8b0 Merge 968da71db3f903d9ed108f2a1a039cfa650ed59c into 5ee0e109a2ca4b894a4486f4a1d83f1f2d70d483
Switched to a new branch 'master'
Branch 'master' set up to track remote branch 'master' from 'origin'.
cargo bench -- --save-baseline master
   Compiling num-traits v0.2.14
   Compiling rhai v0.19.15
   Compiling casbin v2.0.7 (/home/runner/work/casbin-rs/casbin-rs)
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> benches/benchmark.rs:1:1
  |
1 | #![feature(test)]
  | ^^^^^^^^^^^^^^^^^

error: aborting due to previous error

ref - https://github.com/casbin/casbin-rs/pull/242/checks?check_run_id=2285035133

@hsluoyz hsluoyz self-assigned this Apr 8, 2021
@hsluoyz hsluoyz removed the help wanted Extra attention is needed label Apr 8, 2021
@0xethsign
Copy link
Member

0xethsign commented Apr 11, 2021

#250 adds this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants