feat: serialize integers higher than u32 in hex format #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to current naive approach for this serde as hex, only tuple of integers/felts are supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of interop required by Cainome data are JavaScript clients.
JavaScript uses the IEEE 754 standard for floating-point arithmetic, which can safely represent integers up to 2^53 - 1.
Hence, any integer greater than
u32are serialized usinglower hexformat.Current support if for single value and tuple. In a tuple, if one value is subject to be serialized with
hex, all the values are actually required to support lower hex format.This might be a limitation in some situations though.