Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cairo Serde Derive #57

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Cairo Serde Derive #57

merged 6 commits into from
Oct 2, 2024

Conversation

neotheprogramist
Copy link
Contributor

@neotheprogramist neotheprogramist commented Sep 21, 2024 •
edited by piniom
Loading

This is PR has another one stacked on top.

glihm
glihm reviewed Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @neotheprogramist! Enum shouldn't be too complicated to have we may tackle them in an other PR if necessary.

Some tests and ready to go! 🚀

Thanks a lot for the work on that.

crates/cairo-serde-derive/src/lib.rs Outdated Show resolved Hide resolved
crates/cairo-serde-derive/src/lib.rs Outdated Show resolved Hide resolved
crates/cairo-serde-derive/src/lib.rs Outdated Show resolved Hide resolved
@piniom piniom marked this pull request as ready for review September 30, 2024 19:42
glihm
glihm reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piniom thanks for the latest fixes, this looks great!

Could you add some tests for some structs with vectors as you've done, just to have some for the CI coverage and ensure we don't break this easily. :)

@piniom
Implemented serde_derive for enums (#60)
330cc58 
* macros: Implemented serde_derive for enums

* clippy

* added derive tests
@piniom
Copy link
Collaborator

piniom commented Oct 1, 2024

@glihm I've merged the stacked PR with enums. I've also added some tests.

@piniom piniom requested a review from glihm October 1, 2024 16:15
glihm
glihm approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the work on that guys!
Just wondering if we should name it differently than CairoSerde as it's the same name as the trait though.

Might be renamed later. :)

@glihm glihm merged commit 188d3d5 into main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piniom piniom piniom left review comments

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neotheprogramist @piniom @glihm