This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
offchain: adjust code to avoid some clippy warnings #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By replacing new() with create(), we can circumvent https://rust-lang.github.io/rust-clippy/master/index.html#/new_ref for State-like types.
renan061
approved these changes
Jul 31, 2023
| @@ -271,7 +271,7 @@ struct IdleState { | |||
| } | |||
|
|
|||
| impl IdleState { | |||
| fn new(data: SharedStateData) -> Box<dyn State> { | |||
| fn create(data: SharedStateData) -> Box<dyn State> { | |||
| Box::new(Self { data }) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
To avoid using create, we can change this to:
impl IdleState {
fn new(data: SharedStateData) -> Self {
Self { data }
}
}
And then we can do:
Some(Box::new(IdleState::new(self.data)))
| @@ -396,7 +396,7 @@ struct InspectState { | |||
| } | |||
|
|
|||
| impl InspectState { | |||
| fn new( | |||
| fn create( | |||
There was a problem hiding this comment.
Same for this other guys.
What do you think?
|
Obsoleted by cartesi/rollups-node#47 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no strong opinions about the changes made at 2657bd5 to the
Statesub-types to meet new_ret_no_self. We can easily dispense with it and move forward if you prefer.As stated at cartesi/rollups-node#37 (comment), we're still going to miss changes to meet module_inception. Also, as mentioned at cartesi/rollups-node#37 (comment), I see no reason to fix too_many_arguments warning.
Closes cartesi/rollups-node#37