feat: Add version log #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Avoid recording time of build. It goes against reproducible build motto. |
fmoura
force-pushed
the
feature/log-version
branch
from
152cb11
to
dcfcf88
Compare
gligneul
reviewed
Sep 14, 2023
gligneul
reviewed
Sep 14, 2023
gligneul
reviewed
Sep 14, 2023
fmoura
force-pushed
the
feature/log-version
branch
8 times, most recently
from
af6473e
to
bcca7cd
Compare
fmoura
force-pushed
the
feature/log-version
branch
from
bcca7cd
to
39cdec0
Compare
fmoura
force-pushed
the
feature/log-version
branch
2 times, most recently
from
fc41bad
to
1cb321f
Compare
gligneul
suggested changes
Sep 26, 2023
marcelstanley
requested changes
Sep 26, 2023
fmoura
force-pushed
the
feature/log-version
branch
3 times, most recently
from
460982a
to
dabd72f
Compare
gligneul
reviewed
Sep 29, 2023
| @@ -25,7 +25,7 @@ pub async fn start( | |||
| config: DispatcherConfig, | |||
| metrics: DispatcherMetrics, | |||
| ) -> Result<(), DispatcherError> { | |||
| info!("Setting up dispatcher with config: {:?}", config); | |||
| info!("Setting up dispatcher"); | |||
There was a problem hiding this comment.
We could remove this log since it doesn't add much else.
There was a problem hiding this comment.
Sure. Could that be a "trace" instead of "info" then, as logs also acts as "execution markers" that helps spot bugs. What do you think?
There was a problem hiding this comment.
Changing it to trace is fine as well.
fmoura
force-pushed
the
feature/log-version
branch
2 times, most recently
from
0a699be
to
d30ef2a
Compare
|
close #8 |
7 tasks
gligneul
suggested changes
Oct 2, 2023
fmoura
force-pushed
the
feature/log-version
branch
from
d30ef2a
to
cd21dcd
Compare
marcelstanley
previously approved these changes
Oct 3, 2023
fmoura
force-pushed
the
feature/log-version
branch
4 times, most recently
from
9ec5208
to
c9f94e4
Compare
gligneul
reviewed
Oct 4, 2023
fmoura
force-pushed
the
feature/log-version
branch
from
cffbcb3
to
706527c
Compare
gligneul
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding as a Draft to check if the way the "Versioning" Log appears now is the expected one