Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add machine emulator C API bindings #424

Merged
merged 2 commits into from
Aug 15, 2024
Merged

feat: add machine emulator C API bindings #424

merged 2 commits into from
Aug 15, 2024

Conversation

renan061
Copy link
Contributor

From #335.

@renan061 renan061 self-assigned this May 22, 2024
@renan061 renan061 mentioned this pull request May 22, 2024
Closed
@renan061 renan061 changed the base branch from main to next/2.0 May 22, 2024 13:59
@renan061
Copy link
Contributor Author

This code has been extensively reviewed in the original PR.
(Missing test integration with the CI for merge.)

@renan061 renan061 force-pushed the feature/emulator-bindings branch 2 times, most recently from d6f99f6 to 3582cfe Compare May 22, 2024 15:24
@marcelstanley marcelstanley added this to the 2.0.0 milestone May 22, 2024
@marcelstanley marcelstanley added the #feat:machine-advancer Feature: machine advancer label May 22, 2024
marcelstanley
marcelstanley reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@marcelstanley marcelstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a few comments about the CLI and the changelog for now, while the work is in progress.

CHANGELOG.md Outdated Show resolved Hide resolved
cmd/cartesi-machine/main.go Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the feature/emulator-bindings branch 17 times, most recently from 4648bbd to e31192e Compare May 27, 2024 18:15
@renan061 renan061 force-pushed the feature/emulator-bindings branch 2 times, most recently from ab7ad59 to 4da0f72 Compare June 7, 2024 01:17
@renan061
Copy link
Contributor Author

renan061 commented Jun 7, 2024

This is ready to be merged after feature/dockerfile merges.

@renan061 renan061 force-pushed the feature/dockerfile branch 2 times, most recently from 12f069d to 5b38dac Compare June 13, 2024 01:12
Base automatically changed from feature/dockerfile to next/2.0 June 13, 2024 17:09
@renan061
Copy link
Contributor Author

We can merge this now.

This was referenced Jun 19, 2024
Open
Open
@vfusco vfusco force-pushed the next/2.0 branch 2 times, most recently from a65d62d to d60173a Compare July 9, 2024 14:46
@marcelstanley marcelstanley requested a review from a team July 12, 2024 18:55
@renan061 renan061 force-pushed the feature/emulator-bindings branch 2 times, most recently from 96f8253 to 7cc7f11 Compare July 19, 2024 16:31
@fmoura
Copy link
Contributor

fmoura commented Jul 20, 2024

Steps needed to install machine-emulator related dependencies should be part of this PR?
I have followed the ones extracted from reading the Dockerfile, so I could execute the tests locally

fmoura
fmoura reviewed Jul 22, 2024
View reviewed changes
pkg/emulator/emulator.go Show resolved Hide resolved
pkg/emulator/emulator_test.go Outdated Show resolved Hide resolved
marcelstanley
marcelstanley reviewed Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@marcelstanley marcelstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have kept the commit from the original author before applying our changes on top of it in order to separate our changes from his and to give him credit for what he did.

Besides that, I have added some suggestions for improvement that should be considered at least when this package is moved to its own repository.

pkg/emulator/emulator.go Show resolved Hide resolved
pkg/emulator/emulator.go Show resolved Hide resolved
pkg/emulator/emulator.go Show resolved Hide resolved
pkg/emulator/emulator.go Show resolved Hide resolved
pkg/emulator/emulator.go Show resolved Hide resolved
pkg/emulator/htif.go Outdated Show resolved Hide resolved
pkg/emulator/emulator_test.go Show resolved Hide resolved
@renan061
Copy link
Contributor Author

renan061 commented Aug 8, 2024

Steps needed to install machine-emulator related dependencies should be part of this PR? I have followed the ones extracted from reading the Dockerfile, so I could execute the tests locally

Don't think so. In the future, we will use testcontainers or something like that.
Also, this module will be moved to another github repository handled by the machine team.

@renan061 renan061 force-pushed the feature/emulator-bindings branch 2 times, most recently from 0e3d66a to a747e20 Compare August 8, 2024 14:25
@marcelstanley marcelstanley self-requested a review August 15, 2024 15:15
marcelstanley
marcelstanley approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@marcelstanley marcelstanley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renan061 I have resolved all suggestions but we should create a ticket for the handover of these bindings to the machine team along with all suggested improvements

@renan061 renan061 merged commit 8870048 into next/2.0 Aug 15, 2024
6 checks passed
@renan061 renan061 deleted the feature/emulator-bindings branch August 15, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoura fmoura fmoura approved these changes

@marcelstanley marcelstanley marcelstanley approved these changes

@vfusco vfusco Awaiting requested review from vfusco

Assignees

@renan061 renan061

Labels
#feat:machine-advancer Feature: machine advancer
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@renan061 @fmoura @marcelstanley