feat: hide internal services behind proxy #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torives
added
no changelog
torives
force-pushed
the
feature/proxy
branch
2 times, most recently
from
755f6f2
to
19344bd
Compare
gligneul
reviewed
Jan 24, 2024
torives
force-pushed
the
feature/proxy
branch
from
19344bd
to
8f9d7b3
Compare
torives
force-pushed
the
feature/proxy
branch
from
8f9d7b3
to
aa3ab1a
Compare
torives
force-pushed
the
feature/proxy
branch
from
aa3ab1a
to
77db8b2
Compare
Modifies HttpService to act as a reverse proxy. Calls to /graphql, /inspect, /rollups, and /metrics endpoints are now received by it and forwarded to graphql-server, inspect-server, host-runner, and dispatcher respectively. The ports used by these services needn't be exposed anymore, making HttpService the single point of access to the node's APIs. This a is a step towards the goal of transforming these services into golang modules.
gligneul
force-pushed
the
feature/proxy
branch
from
77db8b2
to
de697a3
Compare
gligneul
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies HttpService to act as a reverse proxy. Calls to /graphql, /inspect, /rollups, and /metrics endpoints are now received by it and forwarded to graphql-server, inspect-server, host-runner, and dispatcher respectively. The ports these services use needn't be exposed anymore, making HttpService the single access point to the node's APIs.
This is a step towards transforming these services into Golang modules.
Closes #241