Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removed snapshot storage #267

Merged
merged 3 commits into from
Jan 24, 2024
Merged

refactor: removed snapshot storage #267

merged 3 commits into from
Jan 24, 2024

Conversation

gligneul
Copy link
Contributor

We have a few reasons to remove this feature:

  1. Currently, it is not being used because the production environment doesn't persist the snapshot.
  2. Not having this feature will make the transition to Go easier.
  3. It fixes the Advance runner fails to start in later epochs after input stream is wiped #196 bug.
  4. This feature will not work with the output unification changes in the server manager.

Close #196

@gligneul gligneul added the #feat:multi-dapp Feature: multi-dapp node label Jan 19, 2024
@gligneul gligneul added this to the 1.3.0 milestone Jan 19, 2024
@gligneul gligneul self-assigned this Jan 19, 2024
@gligneul gligneul force-pushed the feature/remove-snapshots branch 6 times, most recently from 68f4482 to 1af3a18 Compare January 19, 2024 20:47
marcelstanley
marcelstanley reviewed Jan 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@gligneul gligneul force-pushed the feature/remove-snapshots branch 3 times, most recently from 1c3565c to 08784db Compare January 22, 2024 19:13
endersonmaia
endersonmaia reviewed Jan 23, 2024
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
@gligneul gligneul force-pushed the feature/remove-snapshots branch 2 times, most recently from 09b048c to 6f2f17d Compare January 23, 2024 17:48
@gligneul gligneul merged commit 9683506 into main Jan 24, 2024
5 checks passed
@gligneul gligneul deleted the feature/remove-snapshots branch January 24, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstanley marcelstanley marcelstanley left review comments

@endersonmaia endersonmaia endersonmaia left review comments

@torives torives torives approved these changes

@renan061 renan061 Awaiting requested review from renan061

Assignees

@gligneul gligneul

Labels
#feat:multi-dapp Feature: multi-dapp node
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Advance runner fails to start in later epochs after input stream is wiped
4 participants
@gligneul @endersonmaia @torives @marcelstanley