Next #185
Merged
Next #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As cartesi-rollups-node gets built and new services are added, it becomes increasingly cumbersome to set up an environment to test it. The added docker-compose file is meant to simplify the process of manual testing for the time being
Currently, there isn't a need to have multiple implementations of the Service interface. Therefore, this commits replaces it with its only implementation to keep things simple.
We were incorrectly comparing the exit code with the SIGTERM signal. With this fixed, service.Start() won't return an error if the process was killed because its context was canceled
Uses context.Context to cancel services and sync.WaitGroup to wait for them to finish, making the code more idiomatic and easier to read
Since the `commits`, `license-header`, and `go-code-quality` workflows are very simple and share a similar trigger, it made sense to merge them all in a single workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.