-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read input commands to rollups-cli #170
Conversation
50c2930
to
5bac943
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just minor comments.
788440c
to
8bf60c3
Compare
fc3aeb5
to
fa303d5
Compare
d46741b
to
dd491f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; there are just a few minor comments left. I will remove the draft status.
0dea90e
to
576376b
Compare
576376b
to
d7d9620
Compare
e1d5ec4
to
cb1d1fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is broken:
cartesi-rollups-cli read inputs
[91 10 32 32 32 32 123 10 32 32 32 32 32 32 32 32 34 105 110 100 101 120 34 58 32 48 44 10 32 32 32 32 32 32 32 32 34 115 116 97 116 117 115 34 58 32 34 65 67 67 69 80 84 69 68 34 44 10 32 32 32 32 32 32 32 32 34 109 115 103 83 101 110 100 101 114 34 58 32 34 48 120 102 51 57 102 100 54 101 53 49 97 97 100 56 56 102 54 102 52 99 101 54 97 98 56 56 50 55 50 55 57 99 102 102 102 98 57 50 50 54 54 34 44 10 32 32 32 32 32 32 32 32 34 116 105 109 101 115 116 97 109 112 34 58 32 49 55 48 49 51 55 55 56 56 56 44 10 32 32 32 32 32 32 32 32 34 98 108 111 99 107 78 117 109 98 101 114 34 58 32 53 54 44 10 32 32 32 32 32 32 32 32 34 112 97 121 108 111 97 100 34 58 32 34 48 120 54 56 54 57 34 10 32 32 32 32 125 10 93]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I've only left some smaller suggestions regarding documentation and naming things.
321ba81
to
778d3c5
Compare
Me and @gligneul discussed and decided it was best to remove the first parameter from the |
778d3c5
to
557b1d7
Compare
Could you add an entry in the CHANGELOG? |
557b1d7
to
ef6b7f9
Compare
#154