fix(offchain): apply fixes suggested by rust-clippy

Full list of warnings:

- https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
- https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrow
- https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_static_lifetimes
- https://rust-lang.github.io/rust-clippy/master/index.html#/map_flatten
- https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_doc_comments
- https://rust-lang.github.io/rust-clippy/master/index.html#/assign_op_pattern
- https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
- https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy
- https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
- https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
- https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
- https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
- https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
- https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
- https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
- https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
- https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
- https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
- https://rust-lang.github.io/rust-clippy/master/index.html#/comparison_to_empty
- https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_cast

offchain/advance-runner/src/broker.rs

@@ -67,7 +67,7 @@ impl BrokerFacade {
             return Ok(INITIAL_ID.to_owned());
         } else {
             // This won't underflow because we know the epoch is not 0
-            epoch = epoch - 1;
+            epoch -= 1;
         }
 
         tracing::trace!(epoch, "searching for finish epoch input event");
@@ -107,7 +107,7 @@ impl BrokerFacade {
         loop {
             let result = self
                 .client
-                .consume_blocking(&self.inputs_stream, &last_id)
+                .consume_blocking(&self.inputs_stream, last_id)
                 .await;
             if matches!(result, Err(BrokerError::ConsumeTimeout)) {
                 tracing::trace!("consume timed out, retrying");

offchain/advance-runner/src/runner.rs

@@ -146,7 +146,7 @@ impl<Snap: SnapshotManager + std::fmt::Debug + 'static> Runner<Snap> {
 
         let event = self
             .broker
-            .consume_input(&last_id)
+            .consume_input(last_id)
             .await
             .context(ConsumeInputSnafu)?;
         tracing::trace!("input event consumed from broker");

offchain/advance-runner/src/server_manager/conversions.rs

@@ -1,8 +1,8 @@
 // (c) Cartesi and individual authors (see AUTHORS)
 // SPDX-License-Identifier: Apache-2.0 (see LICENSE)
 
-///! This module contains functions to convert from gRPC types to
-///! rollups-events types
+//! This module contains functions to convert from gRPC types to
+//! rollups-events types
 use grpc_interfaces::cartesi_machine::Hash;
 use grpc_interfaces::cartesi_server_manager::{
     Address, OutputEnum, OutputValidityProof, Proof,

offchain/advance-runner/src/server_manager/facade.rs

@@ -187,7 +187,7 @@ impl ServerManagerFacade {
         grpc_call!(self, advance_state, {
             let input_metadata = InputMetadata {
                 msg_sender: Some(Address {
-                    data: input_metadata.msg_sender.inner().clone().into(),
+                    data: (*input_metadata.msg_sender.inner()).into(),
                 }),
                 block_number: input_metadata.block_number,
                 timestamp: input_metadata.timestamp,

offchain/advance-runner/src/snapshot/fs_manager.rs

@@ -89,7 +89,7 @@ impl SnapshotManager for FSSnapshotManager {
 
         let path = fs::read_link(&self.config.snapshot_latest)
             .context(ReadLinkSnafu)?;
-        ensure!(path.is_dir(), BrokenLinkSnafu { path: path.clone() });
+        ensure!(path.is_dir(), BrokenLinkSnafu { path });
         tracing::trace!(?path, "followed latest link");
 
         path.try_into()
@@ -131,7 +131,7 @@ impl SnapshotManager for FSSnapshotManager {
         ensure!(
             snapshot.path.parent() == Some(snapshot_dir),
             WrongDirSnafu {
-                path: snapshot.path.clone()
+                path: snapshot.path
             }
         );
         let (epoch, processed_input_count) = decode_filename(&snapshot.path)?;
@@ -143,7 +143,7 @@ impl SnapshotManager for FSSnapshotManager {
         ensure!(
             snapshot.path.is_dir(),
             NotFoundSnafu {
-                path: snapshot.path.clone()
+                path: snapshot.path
             }
         );
 
@@ -172,7 +172,7 @@ impl SnapshotManager for FSSnapshotManager {
                     path: latest.clone()
                 }
             );
-            fs::remove_file(&latest).context(SetLatestSnafu {
+            fs::remove_file(latest).context(SetLatestSnafu {
                 path: latest.clone(),
             })?;
             tracing::trace!("deleted previous latest symlink");
@@ -188,7 +188,7 @@ impl SnapshotManager for FSSnapshotManager {
 
         // delete other snapshots
         for path in snapshots.iter() {
-            fs::remove_dir_all(&path)
+            fs::remove_dir_all(path)
                 .context(RemoveSnafu { path: path.clone() })?;
         }
         tracing::trace!("deleted previous snapshots");
@@ -204,14 +204,13 @@ fn encode_filename(epoch: u64, processed_input_count: u64) -> String {
 fn decode_filename(path: &Path) -> Result<(u64, u64), FSSnapshotError> {
     let file_name = path
         .file_name()
-        .map(|file_name| file_name.to_str())
-        .flatten()
+        .and_then(|file_name| file_name.to_str())
         .context(DirNameSnafu {
-            path: path.to_owned(),
-        })?;
+        path: path.to_owned(),
+    })?;
     tracing::trace!(file_name, "got snapshot file name");
 
-    let parts: Vec<_> = file_name.split("_").collect();
+    let parts: Vec<_> = file_name.split('_').collect();
     ensure!(
         parts.len() == 2,
         DirNameSnafu {

offchain/data/src/config.rs

@@ -22,7 +22,7 @@ impl RepositoryConfig {
         Redacted::new(format!(
             "postgres://{}:{}@{}:{}/{}",
             urlencoding::encode(&self.user),
-            urlencoding::encode(&self.password.inner()),
+            urlencoding::encode(self.password.inner()),
             urlencoding::encode(&self.hostname),
             self.port,
             urlencoding::encode(&self.db)
@@ -64,7 +64,7 @@ impl From<RepositoryCLIConfig> for RepositoryConfig {
             if cli_config.postgres_password.is_some() {
                 panic!("Both `postgres_password` and `postgres_password_file` arguments are set");
             }
-            match std::fs::read_to_string(&filename) {
+            match std::fs::read_to_string(filename) {
                 Ok(password) => password,
                 Err(e) => {
                     panic!("Failed to read password from file: {:?}", e);

offchain/data/src/pagination.rs

@@ -157,7 +157,7 @@ impl Cursor {
     /// Decode cursor from base64 String
     pub fn decode(value: &str) -> Result<Cursor, Error> {
         let bytes = base64_engine
-            .decode(&value)
+            .decode(value)
             .context(DecodeBase64CursorSnafu)?;
         let offset = std::str::from_utf8(&bytes)
             .context(DecodeUTF8CursorSnafu)?

offchain/data/src/repository.rs

@@ -225,7 +225,7 @@ impl Repository {
 
 /// Generate a boxed query from an input query filter
 impl InputQueryFilter {
-    fn to_query<'a>(&'a self) -> schema::inputs::BoxedQuery<'a, Pg> {
+    fn to_query(&self) -> schema::inputs::BoxedQuery<'_, Pg> {
         use schema::inputs::dsl;
         let mut query = dsl::inputs.into_boxed();
         if let Some(other) = self.index_greater_than {
@@ -242,7 +242,7 @@ impl InputQueryFilter {
 macro_rules! impl_output_filter_to_query {
     ($filter: ty, $table: ident) => {
         impl $filter {
-            fn to_query<'a>(&'a self) -> schema::$table::BoxedQuery<'a, Pg> {
+            fn to_query(&self) -> schema::$table::BoxedQuery<'_, Pg> {
                 use schema::$table::dsl;
                 let mut query = dsl::$table.into_boxed();
                 if let Some(other) = self.input_index {

offchain/dispatcher/src/machine/mod.rs

@@ -10,21 +10,12 @@ use async_trait::async_trait;
 
 use self::rollups_broker::BrokerFacadeError;
 
-#[derive(Debug)]
+#[derive(Debug, Default)]
 pub struct RollupStatus {
     pub inputs_sent_count: u64,
     pub last_event_is_finish_epoch: bool,
 }
 
-impl Default for RollupStatus {
-    fn default() -> Self {
-        RollupStatus {
-            inputs_sent_count: 0,
-            last_event_is_finish_epoch: false,
-        }
-    }
-}
-
 #[async_trait]
 pub trait BrokerStatus: std::fmt::Debug {
     async fn status(&self) -> Result<RollupStatus, BrokerFacadeError>;

offchain/dispatcher/src/machine/rollups_broker.rs

@@ -97,7 +97,7 @@ impl BrokerFacade {
     #[tracing::instrument(level = "trace", skip_all)]
     async fn claim(
         &self,
-        id: &String,
+        id: &str,
     ) -> Result<Option<Event<RollupsClaim>>, BrokerFacadeError> {
         let mut broker = self.broker.lock().await;
         let event = broker
@@ -297,7 +297,7 @@ fn build_next_input(
     let data = RollupsData::AdvanceStateInput(RollupsAdvanceStateInput {
         metadata,
         payload: input.payload.clone().into(),
-        tx_hash: (*input.tx_hash).0.into(),
+        tx_hash: input.tx_hash.0.into(),
     });
 
     RollupsInput {

offchain/dispatcher/src/signer/aws_signer.rs

@@ -88,18 +88,18 @@ impl Signer for AwsSigner {
         &self,
         message: &TypedTransaction,
     ) -> Result<Signature, Self::Error> {
-        inner_aws_signer_call!(&self, sign_transaction, message)
+        inner_aws_signer_call!(self, sign_transaction, message)
     }
 
     async fn sign_typed_data<T: Eip712 + Send + Sync>(
         &self,
         payload: &T,
     ) -> Result<Signature, Self::Error> {
-        inner_aws_signer_call!(&self, sign_typed_data, payload)
+        inner_aws_signer_call!(self, sign_typed_data, payload)
     }
 
     fn address(&self) -> Address {
-        self.address.clone()
+        self.address
     }
 
     fn chain_id(&self) -> u64 {
@@ -111,7 +111,7 @@ impl Signer for AwsSigner {
             key_id: self.key_id.clone(),
             chain_id: chain_id.into(),
             region: self.region.clone(),
-            address: self.address.clone(),
+            address: self.address,
         }
     }
 }

offchain/dispatcher/src/signer/signer.rs

@@ -50,7 +50,7 @@ impl ConditionalSigner {
                 const DEFAULT_ACCOUNT_INDEX: u32 = 0;
                 let index = account_index.unwrap_or(DEFAULT_ACCOUNT_INDEX);
                 let wallet = MnemonicBuilder::<English>::default()
-                    .phrase(mnemonic.clone().as_str())
+                    .phrase(mnemonic.as_str())
                     .index(index)
                     .context(LocalWalletSnafu)?
                     .build()

offchain/graphql-server/src/schema/generate_schema.rs

@@ -24,7 +24,7 @@ fn main() {
     match write!(graphql_schema_file, "{}", graphql_schema) {
         Ok(_) => {}
         Err(e) => {
-            eprintln!("Error writing schema to file {}", e.to_string());
+            eprintln!("Error writing schema to file {}", e);
         }
     }
 }

offchain/host-runner/src/controller.rs

@@ -220,7 +220,7 @@ fn send_response<U>(tx: oneshot::Sender<U>, response: U)
 where
     U: std::fmt::Debug + Send + Sync,
 {
-    if let Err(_) = tx.send(response) {
+    if tx.send(response).is_err() {
         tracing::warn!("failed to send response (channel dropped)");
     }
 }

offchain/host-runner/src/grpc/server_manager.rs

@@ -152,7 +152,7 @@ impl ServerManager for ServerManagerService {
     ) -> Result<Response<FinishEpochResponse>, Status> {
         let request = request.into_inner();
         tracing::info!("received finish_epoch with id={}", request.session_id);
-        if request.storage_directory != "" {
+        if !request.storage_directory.is_empty() {
             tracing::warn!("ignoring storage_directory parameter");
         }
         let response = self
@@ -269,7 +269,7 @@ impl SessionManager {
         processed_input_count: u64,
         controller: Controller,
     ) -> Result<(), Status> {
-        if session_id == "" {
+        if session_id.is_empty() {
             return Err(Status::invalid_argument("session id is empty"));
         }
         let mut entry = self.entry.lock().await;
@@ -305,7 +305,7 @@ impl SessionManager {
     }
 
     async fn try_del_session(&self, request_id: &String) -> Result<(), Status> {
-        self.try_get_session(&request_id)
+        self.try_get_session(request_id)
             .await?
             .try_lock()
             .or(Err(Status::aborted("concurrent call in session")))?
@@ -675,7 +675,7 @@ impl Epoch {
         self.state = EpochState::Finished;
 
         let machine_state_hash = GrpcHash {
-            data: vec![0 as u8; HASH_SIZE],
+            data: vec![0_u8; HASH_SIZE],
         };
         let mut proofs: Vec<GrpcProof> = vec![];
         let index = Token::Int(U256::from(epoch_index));
@@ -893,7 +893,7 @@ impl Epoch {
         &self,
         processed_input_count_within_epoch: u64,
     ) -> Result<(), Status> {
-        if self.get_num_processed_inputs_within_epoch() as u64
+        if self.get_num_processed_inputs_within_epoch()
             != processed_input_count_within_epoch
         {
             Err(Status::invalid_argument(format!(

offchain/host-runner/src/main.rs

@@ -78,7 +78,7 @@ async fn main() {
     if let Err(e) = controller.shutdown().await.await {
         tracing::error!("failed to shutdown controller ({})", e);
     }
-    if let Err(_) = grpc_shutdown_tx.send(()) {
+    if grpc_shutdown_tx.send(()).is_err() {
         tracing::error!("failed to send the shutdown signal to grpc");
     }
     if let Err(e) = grpc_service.await {

offchain/indexer/src/conversions.rs

@@ -1,9 +1,9 @@
 // (c) Cartesi and individual authors (see AUTHORS)
 // SPDX-License-Identifier: Apache-2.0 (see LICENSE)
 
-///! Convert from rollups-events types to rollups-data types.
-///! This code cannot use the From trait because both types are defined in
-///! external crates.
+//! Convert from rollups-events types to rollups-data types.
+//! This code cannot use the From trait because both types are defined in
+//! external crates.
 use chrono::naive::NaiveDateTime;
 
 use rollups_events::{

offchain/inspect-server/src/config.rs

@@ -136,7 +136,7 @@ fn load_config_file<T: Default + serde::de::DeserializeOwned>(
 ) -> Result<T, ConfigError> {
     match config_file {
         Some(config) => {
-            let s = std::fs::read_to_string(&config).context(FileSnafu)?;
+            let s = std::fs::read_to_string(config).context(FileSnafu)?;
 
             let file_config: T = toml::from_str(&s).context(ParseSnafu)?;
 

offchain/inspect-server/src/inspect.rs

@@ -61,7 +61,7 @@ fn respond(
     response_tx: oneshot::Sender<Result<InspectStateResponse, InspectError>>,
     response: Result<InspectStateResponse, InspectError>,
 ) {
-    if let Err(_) = response_tx.send(response) {
+    if response_tx.send(response).is_err() {
         log::warn!("failed to respond inspect request (client dropped)");
     }
 }

offchain/redacted/src/lib.rs

@@ -70,7 +70,7 @@ impl fmt::Debug for RedactedUrl {
             }
         })
         .and_then(|_| {
-            if let Some(_) = url.password() {
+            if url.password().is_some() {
                 url.set_password(Some("***"))
             } else {
                 Ok(())

offchain/rollups-events/src/broker/indexer.rs

@@ -1,12 +1,12 @@
 // (c) Cartesi and individual authors (see AUTHORS)
 // SPDX-License-Identifier: Apache-2.0 (see LICENSE)
 
-///! This module is an indexer-specific extension for the broker
-///!
-///! It would be too complex to implement the indexer extension as a generic broker method.
-///! Instead, we decided to implement the extension that we need for the indexer as a submodule.
-///! This extension should be in this crate because it accesses the Redis interface directly.
-///! (All Redis interaction should be hidden in this crate.)
+//! This module is an indexer-specific extension for the broker
+//!
+//! It would be too complex to implement the indexer extension as a generic broker method.
+//! Instead, we decided to implement the extension that we need for the indexer as a submodule.
+//! This extension should be in this crate because it accesses the Redis interface directly.
+//! (All Redis interaction should be hidden in this crate.)
 use backoff::future::retry;
 use redis::streams::{StreamReadOptions, StreamReadReply};
 use redis::AsyncCommands;
@@ -80,8 +80,7 @@ impl Broker {
             .keys
             .iter_mut()
             .find(|stream| stream.key == input_stream_key)
-            .map(|stream| stream.ids.pop())
-            .flatten();
+            .and_then(|stream| stream.ids.pop());
         if let Some(stream_id) = input_stream_id {
             tracing::trace!("found input event; parsing it");
             let event: Event<RollupsInput> = stream_id.try_into()?;
@@ -93,8 +92,7 @@ impl Broker {
             .keys
             .iter_mut()
             .find(|stream| stream.key == output_stream_key)
-            .map(|stream| stream.ids.pop())
-            .flatten();
+            .and_then(|stream| stream.ids.pop());
         if let Some(stream_id) = output_stream_id {
             tracing::trace!("found output event; parsing it");
             let event: Event<RollupsOutput> = stream_id.try_into()?;

offchain/rollups-events/src/broker/mod.rs

@@ -21,7 +21,7 @@ pub use redacted::{RedactedUrl, Url};
 
 pub mod indexer;
 
-pub const INITIAL_ID: &'static str = "0";
+pub const INITIAL_ID: &str = "0";
 
 /// The `BrokerConnection` enum implements the `ConnectionLike` trait
 /// to satisfy the `AsyncCommands` trait bounds.