fix(config): redact redis endpoint

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Disabled the `authority-claimer` when `CARTESI_EXPERIMENTAL_SUNODO_VALIDATOR_ENABLED` is set to `true`.
+- Redacted the contents of `CARTESI_EXPERIMENTAL_SUNODO_VALIDATOR_REDIS_ENDPOINT`.
 
 ## [1.5.0] 2024-07-22
 

internal/node/config/config.go

@@ -36,7 +36,7 @@ type NodeConfig struct {
 	FeatureDisableMachineHashCheck           bool
 	ExperimentalServerManagerBypassLog       bool
 	ExperimentalSunodoValidatorEnabled       bool
-	ExperimentalSunodoValidatorRedisEndpoint string
+	ExperimentalSunodoValidatorRedisEndpoint Redacted[string]
 	Auth                                     Auth
 }
 
@@ -99,7 +99,7 @@ func FromEnv() NodeConfig {
 	config.ExperimentalSunodoValidatorEnabled = getExperimentalSunodoValidatorEnabled()
 	if config.ExperimentalSunodoValidatorEnabled {
 		config.ExperimentalSunodoValidatorRedisEndpoint =
-			getExperimentalSunodoValidatorRedisEndpoint()
+			Redacted[string]{getExperimentalSunodoValidatorRedisEndpoint()}
 		config.FeatureDisableClaimer = true
 	}
 	if !config.FeatureDisableClaimer && !getExperimentalSunodoValidatorEnabled() {

internal/node/config/config_test.go

@@ -43,3 +43,11 @@ func (s *ConfigTestSuite) TestAuthIsNotSetWhenClaimerIsDisabled() {
 	c := FromEnv()
 	assert.Nil(s.T(), c.Auth)
 }
+
+func (s *ConfigTestSuite) TestExperimentalSunodoValidatorRedisEndpointIsRedacted() {
+	os.Setenv("CARTESI_EXPERIMENTAL_SUNODO_VALIDATOR_ENABLED", "true")
+	os.Setenv("CARTESI_EXPERIMENTAL_SUNODO_VALIDATOR_REDIS_ENDPOINT",
+		"redis://username:p@ssw0rd@hostname:9999")
+	c := FromEnv()
+	assert.Equal(s.T(), "[REDACTED]", c.ExperimentalSunodoValidatorRedisEndpoint.String())
+}

internal/node/services.go

@@ -45,7 +45,7 @@ func getPort(c config.NodeConfig, offset portOffset) int {
 // Get the redis endpoint based on whether the experimental sunodo validator mode is enabled.
 func getRedisEndpoint(c config.NodeConfig) string {
 	if c.ExperimentalSunodoValidatorEnabled {
-		return c.ExperimentalSunodoValidatorRedisEndpoint
+		return c.ExperimentalSunodoValidatorRedisEndpoint.Value
 	} else {
 		return fmt.Sprintf("redis://%v:%v", localhost, getPort(c, portOffsetRedis))
 	}