fix #1170: Use ReentrantLock instead of Object monitors #3
Annotations
40 errors and 3 warnings
|
Build with Gradle:
testing/src/main/java/org/conscrypt/java/security/TestKeyStore.java#L701
warning: [JdkObsolete] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/java/security/TestKeyStore.java#L702
warning: [JdkObsolete] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/java/security/TestKeyStore.java#L943
warning: [JdkObsolete] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/java/security/TestKeyStore.java#L965
warning: [JdkObsolete] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/java/security/AbstractAlgorithmParametersTest.java#L28
warning: [PublicConstructorForAbstractClass] Constructors of on an abstract class can be declared protected as there is never a need for them to be public
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/tlswire/handshake/HelloExtension.java#L95
warning: [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/tlswire/handshake/HelloExtension.java#L95
warning: [MissingSummary] A summary line is required on public/protected Javadocs.
|
|
Build with Gradle:
testing/src/main/java/org/conscrypt/VeryBasicHttpServer.java#L118
warning: [StringSplitter] String.split(String) has surprising behavior
|
|
Build with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L117
warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
|
|
Build with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L355
warning: [InvalidBlockTag] Tag name `VisibleForTesting` is unknown. If this is a commonly-used custom tag, please click 'not useful' and file a bug.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L117
warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L355
warning: [InvalidBlockTag] Tag name `VisibleForTesting` is unknown. If this is a commonly-used custom tag, please click 'not useful' and file a bug.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L27
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L37
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L47
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L117
warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L355
warning: [InvalidBlockTag] Tag name `VisibleForTesting` is unknown. If this is a commonly-used custom tag, please click 'not useful' and file a bug.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L27
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L37
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Test with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L47
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L117
warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L355
warning: [InvalidBlockTag] Tag name `VisibleForTesting` is unknown. If this is a commonly-used custom tag, please click 'not useful' and file a bug.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L27
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L37
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L47
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L117
warning: [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/TrustedCertificateStore.java#L355
warning: [InvalidBlockTag] Tag name `VisibleForTesting` is unknown. If this is a commonly-used custom tag, please click 'not useful' and file a bug.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L27
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L37
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Other checks with Gradle:
platform/src/main/java/org/conscrypt/ct/KnownLogs.java#L47
warning: [MutablePublicArray] Non-empty arrays are mutable, so this `public static final` array is not a constant and can be modified by clients of this class. Prefer an ImmutableList, or provide an accessor method that returns a defensive copy.
|
|
Publish to local Maven repo:
common/src/main/java/org/conscrypt/CertificatePriorityComparator.java#L39
error: unexpected end tag: </p>
|
|
Publish to local Maven repo:
common/src/main/java/org/conscrypt/metrics/CipherSuite.java#L26
error: unexpected text
|
|
Publish to local Maven repo:
common/src/main/java/org/conscrypt/metrics/OptionalMethod.java#L26
error: unknown tag: hide
|
|
|
|
Publish to local Maven repo:
common/src/main/java/org/conscrypt/PSKKeyManager.java#L61
error: unexpected end tag: </p>
|
|
Publish to local Maven repo:
common/src/main/java/org/conscrypt/PSKKeyManager.java#L78
error: unexpected end tag: </p>
|
|
|
|
|
|
Publish to local Maven repo:
common/src/main/java/org/conscrypt/AllocatedBuffer.java#L69
warning: no @param for buffer
|
|
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/[email protected], actions/checkout@v2, actions/setup-go@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Set up JDK 11 for toolchains
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Set up JDK 11 for toolchains
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The logs for this run have expired and are no longer available.
Loading