rm unneeded windows api calls #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`filesystem` already has mostly everything we need, minus LoadLibraryW
rudimentary check to make sure `.asi` files are actual DLL's most likely redundant. but you never know when someone might want to do something weird
carlos-menezes
requested changes
May 12, 2024
dllmain.cpp
Outdated
| WIN32_FIND_DATAW findFileData; | ||
| HANDLE hFind = FindFirstFileW(directory.c_str(), &findFileData); | ||
| char header[2]; | ||
| file.read(header, 2); |
There was a problem hiding this comment.
An error may occur here, so we should check if an error happened (and return FALSE as well).
decided to just compact this up a bit more and introduce logging, along with some more safeguards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filesystemalready has mostly everything we need, minus LoadLibraryWadded a safety check as bonus