Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Full transaction in SnapshotConfirmed #1685

Merged
merged 4 commits into from
Oct 9, 2024
Merged

API: Full transaction in SnapshotConfirmed #1685

merged 4 commits into from
Oct 9, 2024

Commits on Oct 8, 2024

  1. ServerOutput contains full transactions 

    This also updates TxValid to only include the transaction id, such that
transactions are only submitted once per client still. Hence, this will
not change the overall bandwidth requirement on websocket clients, but
will make their implementation significantly easier.

Before, if clients wanted to act on transactions this was a lot easier
to do upon seing `TxValid`. However, this was only confirming local
ledger application and not consensus / enforcability of this transaction
onto the L1.

The new API suggests to do the right thing by making it straight-forward
to act upon seeing a transaction in a `SnapshotConfirmed`.
    @ch1bo @noonio
    ch1bo authored and noonio committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0452525 View commit details
    Browse the repository at this point in the history

  2. Re-generate golden files and realize breaking change to persisted sta… 

    …te events
    @ch1bo @noonio
    ch1bo authored and noonio committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c495eaa View commit details
    Browse the repository at this point in the history

  3. Update hydra clients with new field names

    @ch1bo @noonio
    ch1bo authored and noonio committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6b955ac View commit details
    Browse the repository at this point in the history

  4. Use SnapshotConfirmed instead of TxValid

    @noonio
    noonio committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a125d9b View commit details
    Browse the repository at this point in the history