Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ConditionBuilder): correct role for NON HIERARCHICAL_VARIANT #6117

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(ConditionBuilder): correct role for NON HIERARCHICAL_VARIANT #6117

merged 1 commit into from
Sep 25, 2024

Conversation

amal-k-joy
Copy link
Contributor

@amal-k-joy amal-k-joy commented Sep 25, 2024 •
edited
Loading

Contributes #3776 ,#6124

remove unwanted role from condition builder non-hierarchical variant
Fixes below release review comments from Afsal

  • None of the descendent elements with "row" role is tabbable
  • Verify the
    element with "treegrid" role has keyboard access
  • The element with role "treegrid" owns the child element with the role "grid" that is not one of the allowed role(s): "row, rowgroup"

@amal-k-joy amal-k-joy requested a review from a team as a code owner September 25, 2024 11:18
@amal-k-joy amal-k-joy requested review from davidmenendez and AlexanderMelox and removed request for a team September 25, 2024 11:18
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit af18403
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66f3f18f4334460008555cdb
😎 Deploy Preview https://deploy-preview-6117--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amal-k-joy amal-k-joy added this pull request to the merge queue Sep 25, 2024
Merged via the queue into carbon-design-system:main with commit 6c7823e Sep 25, 2024
22 checks passed
@amal-k-joy amal-k-joy deleted the conditionBuilderAccessblty branch September 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadula-nandan devadula-nandan devadula-nandan approved these changes

@anamikaanu96 anamikaanu96 anamikaanu96 approved these changes

@davidmenendez davidmenendez Awaiting requested review from davidmenendez davidmenendez is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

@AlexanderMelox AlexanderMelox Awaiting requested review from AlexanderMelox AlexanderMelox is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amal-k-joy @devadula-nandan @anamikaanu96