Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): remove redundant aria disabled #6103

Conversation

sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Sep 24, 2024

Closes #4797

Remove redundant aria-disabled in customize columns items

What did you change?

aria-disabled is set to undefined for li element.

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 83ab71b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66f3d1413e55880008d884cc
😎 Deploy Preview https://deploy-preview-6103--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review September 25, 2024 04:35
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner September 25, 2024 04:35
@sangeethababu9223 sangeethababu9223 requested review from matthewgallo and devadula-nandan and removed request for a team September 25, 2024 04:35
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Sep 25, 2024
Merged via the queue into carbon-design-system:main with commit 5b58d50 Sep 25, 2024
20 checks passed
@sangeethababu9223 sangeethababu9223 deleted the fix/datagrid-remove-redundant-aria-disabled branch September 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant aria-disabled in customize columns items
3 participants