Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ellipsis from EditInPlace #6098

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

davidmenendez
Copy link
Contributor

Closes #6082

removes the ellipsis in EditInPlace to alleviate an accessibility and functional issue where you are unable to focus on the input

@davidmenendez davidmenendez requested a review from a team as a code owner September 23, 2024 17:51
@davidmenendez davidmenendez requested review from AlexanderMelox and sangeethababu9223 and removed request for a team September 23, 2024 17:51
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 4a9510e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66f1abb878ae0f0008b53bca
😎 Deploy Preview https://deploy-preview-6098--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexanderMelox AlexanderMelox added this pull request to the merge queue Sep 24, 2024
Merged via the queue into carbon-design-system:main with commit 0b40cce Sep 24, 2024
21 checks passed
@davidmenendez davidmenendez deleted the issue-6082 branch September 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditInPlace: On click not working over ellipsis
4 participants