Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): new decorator prop #18077

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

Closes #18002

Updates Tag to include new decorator prop

Changelog

New

  • new decorator prop, classes, and styles

Changed

  • deprecated slug prop
  • update rendering slug to render the decorator component but still set the size if it's an AILabel
  • updated tests

Testing / Reviewing

Check tag with AILabel storybook ( i think the tooltip still looks a little odd, but maybe something to fix once people start using it and we can have design take a better look)

TODO:

  • remove tag with tooltip before merging!

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7ca5ddc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673795eca6956300089ced7b
😎 Deploy Preview https://deploy-preview-18077--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7ca5ddc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673795ec380fb600084068b2
😎 Deploy Preview https://deploy-preview-18077--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7ca5ddc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673795ecbef0c60008650e25
😎 Deploy Preview https://deploy-preview-18077--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (bceb0a0) to head (7ca5ddc).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
packages/react/src/components/Tag/Tag.tsx 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18077      +/-   ##
==========================================
+ Coverage   81.80%   82.21%   +0.40%     
==========================================
  Files         404      404              
  Lines       14094    14177      +83     
  Branches     4364     4494     +130     
==========================================
+ Hits        11530    11655     +125     
+ Misses       2402     2360      -42     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: Tag
1 participant