-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new decorator prop for ComposedModal
#18075
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ComposedModal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18075 +/- ##
==========================================
+ Coverage 82.14% 82.20% +0.05%
==========================================
Files 404 404
Lines 14117 14161 +44
Branches 4434 4448 +14
==========================================
+ Hits 11597 11641 +44
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good just two small things
Co-authored-by: Ariella Gilmore <[email protected]>
Co-authored-by: Ariella Gilmore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is ready to merge after removing the test story and fixing the format ci check |
Closes #17990
Updates Composed Modal to include new decorator prop
Changelog
New
Changed
Testing / Reviewing
Check dropdown with AILabel storybook and form with AILabel storybook (Composed Modal)
TODO: