Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new decorator prop for ComposedModal #18075

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Gururajj77
Copy link
Contributor

@Gururajj77 Gururajj77 commented Nov 14, 2024

Closes #17990

Updates Composed Modal to include new decorator prop

Changelog

New

  • new decorator prop, classes, and styles

Changed

  • deprecated slug prop
  • update rendering slug to render the decorator component but still set the size if it's an AILabel
  • updated tests

Testing / Reviewing

Check dropdown with AILabel storybook and form with AILabel storybook (Composed Modal)

TODO:

  • remove ComposedModal's "With Decorator" story before merging!

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 03286f3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67376468a63a530008c0bcd7
😎 Deploy Preview https://deploy-preview-18075--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 03286f3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67376468600913000886717e
😎 Deploy Preview https://deploy-preview-18075--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 03286f3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67376468642ec70008f2ee75
😎 Deploy Preview https://deploy-preview-18075--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 changed the title feat: new decorator prop feat: new decorator prop for ComposedModal Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (ad23c63) to head (03286f3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18075      +/-   ##
==========================================
+ Coverage   82.14%   82.20%   +0.05%     
==========================================
  Files         404      404              
  Lines       14117    14161      +44     
  Branches     4434     4448      +14     
==========================================
+ Hits        11597    11641      +44     
+ Misses       2359     2358       -1     
- Partials      161      162       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good just two small things

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! 🎉

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisonjoseph
Copy link
Member

This is ready to merge after removing the test story and fixing the format ci check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: ComposedModal
3 participants