-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect #18069
base: main
Are you sure you want to change the base?
feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect #18069
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18069 +/- ##
==========================================
+ Coverage 81.84% 82.18% +0.34%
==========================================
Files 404 404
Lines 14095 14147 +52
Branches 4364 4468 +104
==========================================
+ Hits 11536 11627 +91
+ Misses 2397 2358 -39
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!! LGTM! Can we also update the Form AILabel story for these components and their fluid components. I tested locally and they all look good!
Closes #17989
Closes #17996
Changelog
New
Changed
Testing / Reviewing
Check ComboBox with AILabel storybook
Check MultiSelect with AILabel storybook
Check FilterableMultiSelect with AILabel storybook
TODO:remove test content from storybook