Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect #18069

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Nov 13, 2024

Closes #17989
Closes #17996

Changelog

New

  • new decorator prop for ComboBox
  • new decorator prop for MultiSelect
  • new decorator prop for FilterableMultiSelect

Changed

  • deprecated slug prop for ComboBox
  • deprecated slug prop for MultiSelect
  • deprecated slug prop for FilterableMultiSelect
  • update rendering slug to render the decorator component but still set the size if it's an AILabel for ComboBox, FilterableMultiSelect and MultiSelect
  • updated tests

Testing / Reviewing

Check ComboBox with AILabel storybook
Check MultiSelect with AILabel storybook
Check FilterableMultiSelect with AILabel storybook

TODO:remove test content from storybook

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit de48dcd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6735327afb426000088e536b
😎 Deploy Preview https://deploy-preview-18069--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit de48dcd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6735327a2bebac000832fa0f
😎 Deploy Preview https://deploy-preview-18069--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fb5bf6a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67351fcd29ed330008cc5f30
😎 Deploy Preview https://deploy-preview-18069--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph changed the title feat(combobox): replace slug prop with decorator feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect, Select Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit de48dcd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6735327a782e3e00085859de
😎 Deploy Preview https://deploy-preview-18069--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph changed the title feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect, Select feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect Nov 13, 2024
@alisonjoseph alisonjoseph marked this pull request as ready for review November 13, 2024 23:13
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.18%. Comparing base (664408d) to head (de48dcd).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/react/src/components/ComboBox/ComboBox.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18069      +/-   ##
==========================================
+ Coverage   81.84%   82.18%   +0.34%     
==========================================
  Files         404      404              
  Lines       14095    14147      +52     
  Branches     4364     4468     +104     
==========================================
+ Hits        11536    11627      +91     
+ Misses       2397     2358      -39     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! LGTM! Can we also update the Form AILabel story for these components and their fluid components. I tested locally and they all look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: Multiselect, FilterableMultiSelect Decorator: ComboBox
2 participants