-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement codemod ibm-products-update-userprofileimage #18058
base: main
Are you sure you want to change the base?
feat: implement codemod ibm-products-update-userprofileimage #18058
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18058 +/- ##
==========================================
- Coverage 82.10% 82.06% -0.04%
==========================================
Files 404 404
Lines 14107 14113 +6
Branches 4426 4380 -46
==========================================
Hits 11582 11582
- Misses 2363 2368 +5
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file necessary? How is it used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tay1orjones Thanks for reviewing!
This file is a sample file which is used for demo purpose.
Closes 6308
This PR updates the @carbon/upgrade package with a new transform ibm-products-update-userprofileimage, to update the UserProfileImage to UserAvatar.
Changelog
New
Changed
Testing / Reviewing
Try out the Codemod locally by:
./bin/carbon-upgrade.js migrate list
to verify a new entry ibm-products-update-userprofileimage (Rewrites UserProfileImage to UserAvatar) is presentnpx jest transforms/__tests__/ibm-products-update-userprofileimage-test.js
and verify test result./bin/carbon-upgrade.js migrate ibm-products-update-userprofileimage fixtures/ibm-products-update-userprofileimage-sample.jsx -w
to try the Codemod. ( Select the /carbon/packages/upgrade as workspace)