fix: Added 1rem padding to pagination nav stories #18049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18049 +/- ##
==========================================
+ Coverage 82.14% 82.16% +0.01%
==========================================
Files 404 404
Lines 14117 14127 +10
Branches 4434 4389 -45
==========================================
+ Hits 11597 11607 +10
Misses 2359 2359
Partials 161 161 ☔ View full report in Codecov by Sentry. |
riddhybansal
approved these changes
Nov 12, 2024
|
I also missed the different sizes of pagination. Here's the update.
|
2nikhiltom
approved these changes
Nov 13, 2024
guidari
added
status: needs tests
guidari
force-pushed
the
fix-pagination
branch
from
d8eab51
to
882ef85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a 1rem padding to make the stories look better on small screens
Added a switch case to check what is the PaginationNav size to set the number of pages to fit hte screen
Testing / Reviewing