Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio-button): add new decorator prop #18029

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Nov 8, 2024

Closes #18003

Updates radio-button to include new decorator prop

Changelog

New

  • new decorator prop, classes, and styles

Changed

  • deprecated slug prop
  • update rendering slug to render the decorator component but still set the size if it's an AILabel
  • updated tests

Testing / Reviewing

Check radiobutton with AILabel storybook

TODO:

  • remove RadioButton with tooltip before merging!

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a2f30bf
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673796e97ff78e00089daa7b
😎 Deploy Preview https://deploy-preview-18029--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a2f30bf
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673796e90e59d2000836cdb8
😎 Deploy Preview https://deploy-preview-18029--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a2f30bf
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673796e969ac74000824b5b5
😎 Deploy Preview https://deploy-preview-18029--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (bceb0a0) to head (a2f30bf).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18029      +/-   ##
==========================================
+ Coverage   81.80%   82.21%   +0.41%     
==========================================
  Files         404      404              
  Lines       14094    14173      +79     
  Branches     4364     4490     +126     
==========================================
+ Hits        11530    11653     +123     
+ Misses       2402     2359      -43     
+ Partials      162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review November 8, 2024 21:05
@ariellalgilmore ariellalgilmore requested review from a team as code owners November 8, 2024 21:05
Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this looks good to me but , when I go to playground and try to add decorator its default value is giving me this error. I think default value should be something that gives an idea to user how decorator works or what kind of value should be passed.

image

@guidari
Copy link
Contributor

guidari commented Nov 13, 2024

Hey @ariellalgilmore
I noticed that when we click in the Tooltip the radio is being selected. Is that an expected behaivour or we should use event.stopPropagation to avoid that?

@ariellalgilmore
Copy link
Member Author

@guidari i was wondering the same thing haha, but this approach makes sense to me: #18040 (comment)

@alisonjoseph alisonjoseph added this pull request to the merge queue Nov 15, 2024
@alisonjoseph alisonjoseph removed this pull request from the merge queue due to a manual request Nov 15, 2024
@alisonjoseph
Copy link
Member

oops almost merged this with the tooltip test story still in there 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: RadioButton
4 participants