-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(radio-button): add new decorator prop #18029
base: main
Are you sure you want to change the base?
feat(radio-button): add new decorator prop #18029
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18029 +/- ##
==========================================
+ Coverage 81.80% 82.21% +0.41%
==========================================
Files 404 404
Lines 14094 14173 +79
Branches 4364 4490 +126
==========================================
+ Hits 11530 11653 +123
+ Misses 2402 2359 -43
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
…ecorator' into feat/radio-button-decorator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ariellalgilmore |
@guidari i was wondering the same thing haha, but this approach makes sense to me: #18040 (comment) |
oops almost merged this with the tooltip test story still in there 😅 |
Closes #18003
Updates radio-button to include new decorator prop
Changelog
New
Changed
Testing / Reviewing
Check radiobutton with AILabel storybook
TODO: