-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utilities/date-and-time/relative): add localization for "just now" #17878
base: main
Are you sure you want to change the base?
feat(utilities/date-and-time/relative): add localization for "just now" #17878
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17878 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 404 404
Lines 14151 14151
Branches 4468 4438 -30
=======================================
Hits 11631 11631
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Localizes the "just now" variant for relative time formats occurring when an event has happened <=59s ago. The reference (en-US) wis changed to "now" as this allows us to utilize the Internationalization API for translating into other locales.
Changelog
Changed
numeric: 'auto'
and pretend the event happened 0 seconds ago to return the localized "now" string.Removed
packages/utilities
andpackages/utilities-react