Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify unary for Sass #17595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankharkins
Copy link

@frankharkins frankharkins commented Sep 27, 2024

Closes #17593

https://sass-lang.com/documentation/breaking-changes/strict-unary/

This line causes a deprecation warning in newer versions of Sass. This PR makes a small edit to solve the warning. This shouldn't change the behaviour of the style as Sass interprets the syntax as a subtraction. This is also most likely what the original author intended, otherwise they could have omitted the second -$spacing-05.

Changelog

Changed

Testing / Reviewing

Probably easiest way to verify this is to go to the CodeSandbox repro and add the space to node_modules/@carbon/styles/scss/components/modal/_modal.scss (L128).

Copy link
Contributor

github-actions bot commented Sep 27, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@frankharkins
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ccb9344
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66f6a9bacc04560008a35d03
😎 Deploy Preview https://deploy-preview-17595--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ccb9344
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66f6a9ba28bd550008b38ee8
😎 Deploy Preview https://deploy-preview-17595--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Strict unary deprecation in Sass
1 participant