Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ComboBox readonly state fixed #17457

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/react/src/components/ComboBox/ComboBox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,12 @@ const ComboBox = forwardRef(
if (onToggleClick) {
onToggleClick(event);
}
if (readOnly) {
// Prevent the list from opening if readOnly is true
event.preventDownshiftDefault = true;
event?.persist?.();
return;
}

if (event.target === textInput.current && isOpen) {
event.preventDownshiftDefault = true;
Expand Down Expand Up @@ -749,6 +755,15 @@ const ComboBox = forwardRef(
evt.preventDefault();
}
},
onClick: (evt: MouseEvent<HTMLInputElement>) => {
// Prevent the default behavior which would open the list
evt.preventDefault();
// Focus on the element as per readonly input behavior
evt.currentTarget.focus();
},
onFocus: (evt: FocusEvent<HTMLInputElement>) => {
evt.target.blur(); // Immediately remove focus when received
},
}
: {};

Expand Down Expand Up @@ -879,6 +894,13 @@ const ComboBox = forwardRef(
toggleMenu();
}
}
if (readOnly) {
// Prevent default behavior for all keys except Tab when readOnly
if (event.key !== 'Tab') {
event.preventDefault();
}
return;
}
},
})}
{...rest}
Expand Down
Loading