Add typescript types to fluid date picker and its skeleton state and fluid datepicker input #17385
Conversation
|
Hey there @tay1orjones @Gururajj77 there is not any props defined for FluidDatePickerInput so what should be the type for this since no interface! |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
We can convert the file to |
riddhybansal
force-pushed
the
add_typescript_types_to_FluidDatePicker
branch
from
3bb9e56
to
2952677
Compare
| ) { | ||
| return ( | ||
| <FormContext.Provider value={{ isFluid: true }}> | ||
| <DatePickerInput ref={ref} {...other} /> | ||
| <DatePickerInput id={''} labelText={undefined} ref={ref} {...other} /> |
There was a problem hiding this comment.
Could the id and labelText be removed here so users can still configure them?
There was a problem hiding this comment.
id and labelText are required props in DatepickerInput so need to pass something. What can we do other than this?
There was a problem hiding this comment.
@riddhybansal If they're required in DatePickerInput, they should be required here in FluidDatePickerInput too and passed through ...other.
If typescript isn't automatically inferring that relationship then I think we need to explicitly specify that FluidDatePickerInput inherits/extends DatePickerInputProps.
|
@Gururajj77 do we need to explicitly specify that FluidDatePickerInput inherits DatePickerInputProps? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17385 +/- ##
=======================================
Coverage 76.92% 76.93%
=======================================
Files 408 408
Lines 13979 13980 +1
Branches 4339 4291 -48
=======================================
+ Hits 10754 10755 +1
Misses 3052 3052
Partials 173 173 ☔ View full report in Codecov by Sentry. |
riddhybansal
force-pushed
the
add_typescript_types_to_FluidDatePicker
branch
from
aed133c
to
0c40f27
Compare
Closes #17366
Closes #17365
Added typescript types to fluid date picker and its skeleton state and fluid datepicker input
Changelog
Changed
Testing / Reviewing
FluidDatePickerInput, FluidDatePicker and its skeleton should work as intended.