feat(notification): rename StaticNotification to Callout #17376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
added
status: ready for review 👀
and removed
status: WIP 👩💻
DO NOT MERGE
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17376 +/- ##
==========================================
+ Coverage 76.98% 77.08% +0.09%
==========================================
Files 409 409
Lines 14001 14014 +13
Branches 4353 4305 -48
==========================================
+ Hits 10779 10803 +24
+ Misses 3049 3041 -8
+ Partials 173 170 -3 ☔ View full report in Codecov by Sentry. |
kennylam
approved these changes
Oct 1, 2024
2nikhiltom
approved these changes
Oct 1, 2024
packages/upgrade/transforms/__testfixtures__/refactor-to-callout.output.js
Show resolved
Hide resolved
…name-static-notification-callout
Merged
via the queue into
carbon-design-system:main
with commit Oct 1, 2024
c0d2b32
36 checks passed
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Oct 2, 2024
…gn-system#17376) * feat(notification): rename StaticNotification to Callout * chore: update test fixtures * docs(notification): update StaticNotification stories * chore: update snaps * refactor(callout): reworked import portion of codemod * fix(callout): codemod improvements * fix(callout): update codemod test fixture output formatting
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17375
Related carbon-design-system/carbon-website#4218, carbon-design-system/carbon-website#4243
Changelog
New
Changed
Testing / Reviewing