feat: ErrorBoundary avt test #14754
Merged
feat: ErrorBoundary avt test #14754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Oct 4, 2023
guidari
requested changes
Oct 6, 2023
There was a problem hiding this comment.
Hey @andreancardona the tests LGTM! 🚀
Just a couple notes about the declaration, before merge.
Co-authored-by: Guilherme Datilio Ribeiro <[email protected]>
Co-authored-by: Guilherme Datilio Ribeiro <[email protected]>
guidari
approved these changes
Oct 6, 2023
Merged
via the queue into
carbon-design-system:main
with commit Oct 10, 2023
3166c31
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14753
Added keyboard navigation to
ErrorBoundarycomponent.Added new file e2e/components/DefinitionTooltip /ErrorBoundary-test.avt.e2e.js
Testing / Reviewing:
yarn playwright test components/ErrorBoundary/ErrorBoundary-test.avt.e2e.jsEnsure the test pass.
Ensure that the expected navigation is covered.