Skip to content

Commit

Permalink
fix(modal): replace svg with inline-svg (#128)
Browse files Browse the repository at this point in the history
  • Loading branch information
tw15egan authored and hellobrian committed May 25, 2017
1 parent 4423a93 commit 1b1c6f6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
9 changes: 4 additions & 5 deletions src/components/modal/modal--nofooter.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@
<h4 class="bx--modal-header__label">Label (Optional)</h4>
<h2 class="bx--modal-header__heading">Modal Title</h2>
<button class="bx--modal-close" type="button" data-modal-close data-modal-primary-focus>
<svg
class="bx--modal-close__icon"
>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--close"></use>
<svg class="bx--modal-close__icon" width="10" height="10" viewBox="0 0 10 10" fill-rule="evenodd">
<path d="M9.8 8.6L8.4 10 5 6.4 1.4 10 0 8.6 3.6 5 .1 1.4 1.5 0 5 3.6 8.6 0 10 1.4 6.4 5z"></path>
</svg>
</button>
</div>

<div class="bx--modal-content">
<p>Passive modal notifications should only appear if there is an action the user needs to address immediately. Passive modal notifications are persistent on the screen.</p>
<p>Passive modal notifications should only appear if there is an action the user needs to address immediately. Passive
modal notifications are persistent on the screen.</p>
</div>
</div>
</div>
6 changes: 2 additions & 4 deletions src/components/modal/modal.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@
<h4 class="bx--modal-header__label">Label (Optional)</h4>
<h2 class="bx--modal-header__heading">Modal Title</h2>
<button class="bx--modal-close" type="button" data-modal-close>
<svg
class="bx--modal-close__icon"
>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--close"></use>
<svg class="bx--modal-close__icon" width="10" height="10" viewBox="0 0 10 10" fill-rule="evenodd">
<path d="M9.8 8.6L8.4 10 5 6.4 1.4 10 0 8.6 3.6 5 .1 1.4 1.5 0 5 3.6 8.6 0 10 1.4 6.4 5z"></path>
</svg>
</button>
</div>
Expand Down

0 comments on commit 1b1c6f6

Please sign in to comment.