Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu accessibility tab doc update #4250

Merged
merged 21 commits into from
Sep 23, 2024
Merged

Menu accessibility tab doc update #4250

merged 21 commits into from
Sep 23, 2024

Conversation

alina-jacob
Copy link
Member

@alina-jacob alina-jacob commented Sep 10, 2024 •
edited
Loading

Closes #3796

New

  • [Accessibility Tab] Added content and images for Menu.

Changed

  • [Usage tab] Updated guidance and image for Overflow content (truncated menu item text) .
  • [Usage tab] Updated the RTL image to show the right chevron and command directions.

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Sep 20, 2024 2:25pm

@alina-jacob alina-jacob marked this pull request as ready for review September 11, 2024 18:11
@alina-jacob alina-jacob requested review from a team as code owners September 11, 2024 18:11
laurenmrice
laurenmrice requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good Alina! Left a couple comments below:

src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
src/pages/components/menu/accessibility.mdx Outdated Show resolved Hide resolved
Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Alina! LGTM 🚀

If you have any research or iterations documented in a Figma file or Box note, could you please share them in the issue's comments (like this:)

image

@laurenmrice laurenmrice self-requested a review September 19, 2024 16:08
@tay1orjones tay1orjones enabled auto-merge (squash) September 23, 2024 16:38
@mergify mergify bot mentioned this pull request Sep 23, 2024
Closed
@tay1orjones tay1orjones merged commit 2d19fac into carbon-design-system:main Sep 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore left review comments

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu] create content for the Accessibility tab
7 participants
@alina-jacob @alisonjoseph @tay1orjones @ariellalgilmore @laurenmrice @Kritvi-bhatia17 @alina-jacob-ibm