Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: properly handle close event in simple modal story (#3004) #3016

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

eduardmarcinco
Copy link
Contributor

Closes #3004

@eduardmarcinco eduardmarcinco requested a review from a team as a code owner September 28, 2024 12:09
Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit 9aa8fe9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/66f7f2107486760008d21bda
😎 Deploy Preview https://deploy-preview-3016--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Akshat55 Akshat55 changed the title fix: properly handle close event in simple modal story (#3004) docs: properly handle close event in simple modal story (#3004) Sep 30, 2024
@Akshat55 Akshat55 merged commit 2e5af93 into carbon-design-system:master Sep 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modals are not reopening if we close it by clicking ESC button
2 participants