fixes #284 #285
Merged
fixes #284 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKenyon
approved these changes
Apr 30, 2024
landmanbester
approved these changes
May 2, 2024
| alias_schema.default = defval | ||
| ## see https://github.com/caracal-pipeline/stimela/issues/284. No longer convinced | ||
| ## these parameters should be marked as Hidden. After all, the recipe explicitly specifies them! | ||
| ## mark it as hidden -- no need to expose parameters that are internally set this way |
There was a problem hiding this comment.
Are you leaving this here for posterity?
There was a problem hiding this comment.
For a bit, yes. Want to revisit this after a bit so rather leave my thoughts in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@landmanbester would like your input on this especially, as it tweaks the logic of aliases.
The major change is that aliases for which a value is set inside a step definition (or by the cab default) now propagate up to recipe-level defaults. And they are no longer shown as "Hidden" by
stimela doc.