message: Fix benchmark read reuse test #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows that the BenchmarkUnmarshal_Reuse is broken.
Previously, this benchmark was using the Reset() method to reset the message's arena, which can't be done for reading, as the recently introduced comments indicate. This fixes the benchmark by releasing the previous arena and directly modifying the arena field of the message. In the future, this should be done explicitly by either Reset() or by a new dedicated function.
This adds comments to the Marshal/Unmarshal benchmarks to make it clear their goals and caveats. It also splits the marshalling benchmark into two: one with and one without message reuse.
lthibault
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.