Update README.md #553
Closed
Update README.md #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows a work around that fixes the examples with newer versions of go, and mentioned the tagged release will bix the problem.
|
Thanks for writing this up! Out of curiosity, had you seen this when trying for the first time? It's linked in the "Getting Started" section in the README. I think we ought to clarify instructions either in the root-level README, or in the Wiki (preferred). I'm not sure it's such a good idea to duplicate/fragment instructions in the examples. |
|
After thinking about this some more, I'm closing this issue because go 1.18 isn't supported. In fact, we should probably bump our minimum version to 1.21 at this point. Thank you for submitting this nevertheless. I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This README update shows a work around that fixes the examples with newer versions of go, which mentions using 3.0 or the newest tagged release will fix the problem.