Fix field names that collide with generated names #46 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial fix of capnproto#46 > zenhack commented on Sep 17, 2016: > > if a name would otherwise collide with a go or go-capnpc name, append > a single underscore. e.g. `Struct` becomes `Struct_` Also see capnproto/capnproto#323 This commit changes the generated getter and setter methods for struct fields. If the field name would collide with code generated for any struct such as `Method()` or `String()`, the field getter becomes `Method_()` and the setter becomes `SetMethod_()`. Technically only `Method_()` would be necessary, but who wants to maintain the mental state? If the getter changes, the setter also changing is just simpler conceptually. The capnp files in this repo under `std` have $Go.name() annotations due to capnproto#46. This removes one of them (std/capnp/compat/json.capnp) and updates the unit tests for code coverage testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix of #46
Also see capnproto/capnproto#323
This commit changes the generated getter and setter methods for struct fields. If the field name would collide with code generated for any struct such as
Method()orString(), the field getter becomesMethod_()and the setter becomesSetMethod_().Technically only
Method_()would be necessary, but who wants to maintain the mental state? If the getter changes, the setter also changing is just simpler conceptually.The capnp files in this repo under
stdhave $Go.name() annotations due to #46. This removes one of them (std/capnp/compat/json.capnp) and updates the unit tests for code coverage testing purposes.