-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Handle incoming resolve messages, take 2 #530
Commits on Jun 17, 2023
-
WIP: handle incoming resolve messages.
Still TODO: - We need to handle disembargos with target = (importedCap = ...). - Testing.
Configuration menu - View commit details
-
Copy full SHA for 4d2274a - Browse repository at this point
Copy the full SHA 4d2274aView commit details -
cleanup: remove unnecessary declaration of importClient.
The := below is sufficient, since this isn't actually used before that.
Configuration menu - View commit details
-
Copy full SHA for a006092 - Browse repository at this point
Copy the full SHA a006092View commit details -
Factor some logic out of handleDisembargo.
Also, along the way, use the snapshot from resultsCapTable instead of calling .Snapshot() on the client.
Configuration menu - View commit details
-
Copy full SHA for ae48235 - Browse repository at this point
Copy the full SHA ae48235View commit details -
Configuration menu - View commit details
-
Copy full SHA for e96d054 - Browse repository at this point
Copy the full SHA e96d054View commit details -
Configuration menu - View commit details
-
Copy full SHA for 872202c - Browse repository at this point
Copy the full SHA 872202cView commit details -
Add a test for disembargos on senderPromises.
The test is currently failing; we're getting back an abort message complaining that the export entry is not a promise -- need to investigate. Aside from that failure, this caught a bug: we need to check if ClientState.Metadata is nil, which is possible if the client itself is null, and seems to happen to the promise after it is resolved. TODO: we should de-dup the logic between releaseExport and releaseExports. This is not entirely trivial though, because the latter is executed after we've wiped the exports table.
Configuration menu - View commit details
-
Copy full SHA for c3a169d - Browse repository at this point
Copy the full SHA c3a169dView commit details -
Add another test wrt promise resolution.
...also failing (hanging) for now.
Configuration menu - View commit details
-
Copy full SHA for 78a82e2 - Browse repository at this point
Copy the full SHA 78a82e2View commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d42eb54 - Browse repository at this point
Copy the full SHA d42eb54View commit details -
Get rid of redundant isPromise
...which we were forgetting to set. We can query snapshot for this anyway, so just get rid of it -- single source of truth and all.
Configuration menu - View commit details
-
Copy full SHA for dee0565 - Browse repository at this point
Copy the full SHA dee0565View commit details -
Fix TestDisembargoSenderPromise.
When looking at the target of the promise, we want to look at its *resolution.*
Configuration menu - View commit details
-
Copy full SHA for eecd20f - Browse repository at this point
Copy the full SHA eecd20fView commit details -
leak detection: skip nil snapshots.
Otherwise we get a runtime error sometimes.
Configuration menu - View commit details
-
Copy full SHA for a297d2e - Browse repository at this point
Copy the full SHA a297d2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 849aa07 - Browse repository at this point
Copy the full SHA 849aa07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d80d1f - Browse repository at this point
Copy the full SHA 0d80d1fView commit details -
TestPromiseOrdering: use require, not assert.
...the latter often just results in me staring at cascading errors, which is unhelpful.
Configuration menu - View commit details
-
Copy full SHA for f103d94 - Browse repository at this point
Copy the full SHA f103d94View commit details
Commits on Jun 22, 2023
-
Clean up the way local promises work.
Push the logic for flushing the answerqueue into the Promise type itself. This is much cleaner, and avoids some racy logic that I'm not sure was correct.
Configuration menu - View commit details
-
Copy full SHA for 51facf7 - Browse repository at this point
Copy the full SHA 51facf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f8d2d8 - Browse repository at this point
Copy the full SHA 4f8d2d8View commit details