-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle incoming resolve messages. #480
Commits on Mar 16, 2023
-
WIP: handle incoming resolve messages.
Still TODO: - We need to handle disembargos with target = (importedCap = ...). - Testing.
Configuration menu - View commit details
-
Copy full SHA for a3ffc4e - Browse repository at this point
Copy the full SHA a3ffc4eView commit details
Commits on Mar 18, 2023
-
cleanup: remove unnecessary declaration of importClient.
The := below is sufficient, since this isn't actually used before that.
Configuration menu - View commit details
-
Copy full SHA for 36b13bf - Browse repository at this point
Copy the full SHA 36b13bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cbff97 - Browse repository at this point
Copy the full SHA 3cbff97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fbd8c6 - Browse repository at this point
Copy the full SHA 9fbd8c6View commit details
Commits on Mar 19, 2023
-
Add a test for disembargos on senderPromises.
This caught a bug: we need to check if ClientState.Metadata is nil, which is possible if the client itself is null, and seems to happen to the promise after it is resolved. TODO: we should de-dup the logic between releaseExport and releaseExports. This is not entirely trivial though, because the latter is executed after we've wiped the exports table.
Configuration menu - View commit details
-
Copy full SHA for 2061cfa - Browse repository at this point
Copy the full SHA 2061cfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d50b6ce - Browse repository at this point
Copy the full SHA d50b6ceView commit details
Commits on Mar 21, 2023
-
Fix the ownership semantics for NewLocalPromise
These are much cleaner.
Configuration menu - View commit details
-
Copy full SHA for b11ac49 - Browse repository at this point
Copy the full SHA b11ac49View commit details -
Remove no longer necessary .Release()
...now that the resolver takes ownership.
Configuration menu - View commit details
-
Copy full SHA for a1028be - Browse repository at this point
Copy the full SHA a1028beView commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0799051 - Browse repository at this point
Copy the full SHA 0799051View commit details
Commits on Mar 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9a40e87 - Browse repository at this point
Copy the full SHA 9a40e87View commit details -
Correctly send receiverLoopbacks that target promisedAnswers.
Worryingly, this was manifesting in the test as a deadlock: we hit the error complaining about it not being an import, but then connection shutdown hung, waiting on tasks. I haven't pinned down exactly what was going on there, but this sidesteps the issue by fixing the thing that was causing a connection abort in the first place.
Configuration menu - View commit details
-
Copy full SHA for e46bf47 - Browse repository at this point
Copy the full SHA e46bf47View commit details
Commits on Mar 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 14b7864 - Browse repository at this point
Copy the full SHA 14b7864View commit details
Commits on Mar 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 49578d5 - Browse repository at this point
Copy the full SHA 49578d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a32a77 - Browse repository at this point
Copy the full SHA 3a32a77View commit details -
Clean up the way local promises work.
Push the logic for flushing the answerqueue into the Promise type itself. This is much cleaner, and avoids some racy logic that I'm not sure was correct.
Configuration menu - View commit details
-
Copy full SHA for c78b076 - Browse repository at this point
Copy the full SHA c78b076View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7861ab - Browse repository at this point
Copy the full SHA d7861abView commit details
Commits on May 26, 2023
-
WIP: put a ClientSnapshot in the exports table
...instead of a Client. This is a step towards addressing the tribble 4-way race condition. Currently there are some test failures.
Configuration menu - View commit details
-
Copy full SHA for 2e138f0 - Browse repository at this point
Copy the full SHA 2e138f0View commit details -
ClientSnapshot.Release(): take pointer receiver.
The call to waitRef.Release() in export.go was resolving the receiver too soon, resulting in a leak.
Configuration menu - View commit details
-
Copy full SHA for 9999902 - Browse repository at this point
Copy the full SHA 9999902View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7213fc1 - Browse repository at this point
Copy the full SHA 7213fc1View commit details
Commits on May 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1cc3130 - Browse repository at this point
Copy the full SHA 1cc3130View commit details -
Merge branch 'export-snapshot' into handle-resolve
Has build errors that need fixing.
Configuration menu - View commit details
-
Copy full SHA for 8d71f0b - Browse repository at this point
Copy the full SHA 8d71f0bView commit details -
CapTable: rename Get -> GetClient, Add -> AddClient
I plan on adding *Snapshot versions and eventually storing snapshots internally.
Configuration menu - View commit details
-
Copy full SHA for 91d062a - Browse repository at this point
Copy the full SHA 91d062aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e0023a - Browse repository at this point
Copy the full SHA 5e0023aView commit details -
Configuration menu - View commit details
-
Copy full SHA for abf193b - Browse repository at this point
Copy the full SHA abf193bView commit details -
Remove argument to CapTable.Reset()
This seems like an unnecessary complication, and I don't want to deal with it when porting stuff over to snapshots.
Configuration menu - View commit details
-
Copy full SHA for 76f95d5 - Browse repository at this point
Copy the full SHA 76f95d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61ca9e5 - Browse repository at this point
Copy the full SHA 61ca9e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f967703 - Browse repository at this point
Copy the full SHA f967703View commit details -
WIP: Add a Steal() method to Client and ClientSnapshot
...and use it to catch a bug; the test is failing, need to track it down.
Configuration menu - View commit details
-
Copy full SHA for fe08d87 - Browse repository at this point
Copy the full SHA fe08d87View commit details -
Configuration menu - View commit details
-
Copy full SHA for afeb534 - Browse repository at this point
Copy the full SHA afeb534View commit details -
pogs tests: clone input before inserting.
Otherwise the target message steals the caps, resulting in errors later when we try to read them.
Configuration menu - View commit details
-
Copy full SHA for 7a23f9b - Browse repository at this point
Copy the full SHA 7a23f9bView commit details -
Mark TestDuplicateBootstrap as flaky.
Per capnproto#523, this is currently failing frequently. Mark it as flaky until we're ready to actually deal with it.
Configuration menu - View commit details
-
Copy full SHA for 2372b53 - Browse repository at this point
Copy the full SHA 2372b53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1acb315 - Browse repository at this point
Copy the full SHA 1acb315View commit details -
Configuration menu - View commit details
-
Copy full SHA for 843e8b6 - Browse repository at this point
Copy the full SHA 843e8b6View commit details -
CapTable: maintain snapshots & clients in parallel.
In addition to letting us hand out borrowed references, Storing the snapshots will facilitate code that needs them not to resolve further after AddSnapshot() or SetSnapshot().
Configuration menu - View commit details
-
Copy full SHA for 575916e - Browse repository at this point
Copy the full SHA 575916eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75200fc - Browse repository at this point
Copy the full SHA 75200fcView commit details
Commits on May 28, 2023
-
There are test failures that need debugging though.
Configuration menu - View commit details
-
Copy full SHA for 0a99d60 - Browse repository at this point
Copy the full SHA 0a99d60View commit details