Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused method rpc.Conn.getAnswerQuestion. #474

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Remove unused method rpc.Conn.getAnswerQuestion. #474

merged 1 commit into from
Mar 1, 2023

Conversation

lthibault
Copy link
Collaborator

This isn't used anywhere, despite what the comment says, so it seems like we could delete it.

@lthibault lthibault requested a review from zenhack March 1, 2023 02:09
@lthibault lthibault self-assigned this Mar 1, 2023
@zenhack
Copy link
Contributor

zenhack commented Mar 1, 2023

#348, re-running.

zenhack
zenhack approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@zenhack zenhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

@lthibault lthibault merged commit c57e931 into main Mar 1, 2023
@lthibault lthibault deleted the cleanup/remove-unused-getAnswerQuestion branch March 1, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenhack zenhack zenhack approved these changes

Assignees

@lthibault lthibault

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lthibault @zenhack