Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid use of fmt in the main package. #456

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Avoid use of fmt in the main package. #456

merged 3 commits into from
Feb 20, 2023

Commits on Feb 19, 2023

  1. Avoid use of fmt in the main package. 

    This adds a String() method to ClientHook so we can avoid using fmt for
that, then removes the last use of fmt in the main package, per capnproto#364.

Before closing that issue, I think I'd still like to get it out of the
flowcontrol package hierarchy at least, and maybe elsewhere if
practical.
    @zenhack
    zenhack committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    f9f1b3d View commit details
    Browse the repository at this point in the history

  2. Add a String() method to dummyHook 

    ...so it implements ClientHook again.
    @zenhack
    zenhack committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    e4d46e9 View commit details
    Browse the repository at this point in the history

  3. Remove fmt dependency from the flowcontrol package

    @zenhack
    zenhack committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    348bcf9 View commit details
    Browse the repository at this point in the history