Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #382 #391

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix #382 #391

merged 1 commit into from
Dec 16, 2022

Commits on Dec 16, 2022

  1. Fix capnproto#382

    This reworks the locking such that newPipelineCallMessage &
    newImportCallMessage expect the caller to already be holding the
    connection lock, and then removes the call to syncutil.Without in order
    to comply with sendMessage's contract.
    
    There is a big downside here: it means that it is no longer OK for
    PlaceArgs to call into the RPC subsystem, as it could cause a deadlock.
    
    We're planning on reworking this interface to get rid of PlaceArgs
    anyway (see capnproto#64), and this kind of code is not that common and generally
    easy to avoid, so in the interest of finishing out one batch of
    refactoring before starting the next, I am of the opinion that this is
    probably the right thing to do.
    zenhack committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    1503c95 View commit details
    Browse the repository at this point in the history