First steps reducing fmt usage. #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per capnproto#364, this is a first step on the road to eliminating usage of fmt from the library; it removes most direct uses of it from the exc package. The remaining bits are Failedf and friends. I'd like to just remove these, but that requires changing every downstream call site, and I wanted to keep this patch small for today; I can tackle that when I have a bit more time. I don't think it will be too hard; from a quick skim WrapError covers 99% of the use cases, and the rest won't be hard to replace with things from strconv.
lthibault
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #364, this is a first step on the road to eliminating usage of fmt from the library; it removes most direct uses of it from the exc package. The remaining bits are Failedf and friends. I'd like to just remove these, but that requires changing every downstream call site, and I wanted to keep this patch small for today; I can tackle that when I have a bit more time. I don't think it will be too hard; from a quick skim WrapError covers 99% of the use cases, and the rest won't be hard to replace with things from strconv.