Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-6315 - Support generating Deb822 sources list #186

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Conversation

upils
Copy link
Collaborator

@upils upils commented Feb 13, 2024

Add support for generating deb822 sources list files when building an image.

This feature is enabled via a new field in the Rootfs object of the image definition.

If the user does not explicitly set this value to "true", a warning is displayed explaining this will be the default value at some point in the future.

Once this is merged, we should update our image definitions.

@upils upils force-pushed the deb822-sourceslist branch 4 times, most recently from 43caa56 to 7da359c Compare February 13, 2024 16:09
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: Patch coverage is 63.70370% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 89.25%. Comparing base (950c773) to head (818be56).

Files Patch % Lines
internal/imagedefinition/image_definition.go 54.44% 41 Missing ⚠️
internal/statemachine/classic_states.go 78.37% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   89.88%   89.25%   -0.64%     
==========================================
  Files          13       13              
  Lines        3531     3630      +99     
==========================================
+ Hits         3174     3240      +66     
- Misses        319      350      +31     
- Partials       38       40       +2     
Flag Coverage Δ
unittests 89.25% <63.70%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@upils upils requested a review from sil2100 February 14, 2024 10:33
@upils upils marked this pull request as ready for review February 14, 2024 10:33
@upils upils self-assigned this Feb 15, 2024
sil2100
sil2100 previously approved these changes Feb 21, 2024
Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! One inline indentation comment and a question about the extent of the deb822 migration we're doing in noble. But otherwise, this is good to go.

internal/imagedefinition/README.rst Outdated Show resolved Hide resolved
internal/statemachine/classic.go Show resolved Hide resolved
Copy link

@julian-klode julian-klode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approving this but as commented, the warning could use some rewording

sil2100
sil2100 previously approved these changes Feb 22, 2024
Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Julian's comments, I'm now +1 on it. The wording seems to be fine for me as well. Please proceed!

@upils upils merged commit aa1b377 into main Feb 23, 2024
10 of 13 checks passed
@upils upils deleted the deb822-sourceslist branch February 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants