-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR-6315 - Support generating Deb822 sources list #186
Conversation
43caa56
to
7da359c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 89.88% 89.25% -0.64%
==========================================
Files 13 13
Lines 3531 3630 +99
==========================================
+ Hits 3174 3240 +66
- Misses 319 350 +31
- Partials 38 40 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d13bfde
to
86901c5
Compare
86901c5
to
136bf7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! One inline indentation comment and a question about the extent of the deb822 migration we're doing in noble. But otherwise, this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approving this but as commented, the warning could use some rewording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Julian's comments, I'm now +1 on it. The wording seems to be fine for me as well. Please proceed!
3463b5f
to
8f2d927
Compare
Add support for generating deb822 sources list files when building an image.
This feature is enabled via a new field in the Rootfs object of the image definition.
If the user does not explicitly set this value to "true", a warning is displayed explaining this will be the default value at some point in the future.
Once this is merged, we should update our image definitions.