-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose sysfs overlay option #182
Conversation
Hey @masahiro-nakagawa, As mentionned here #120 (review), can you give us a bit of context of why you need this feature for? @alfonsosanchezbeato @valentindavid Does it make sense to let users set this from the snapd point of view? |
This change allows to pass sysfs-overlay option required to generate a preseeding image which enhances the initial boot time of Ubuntu Core 20. |
This change allows to pass sysfs-overlay option required to generate a preseeding image which enhances the initial boot time of Ubuntu Core 20.
efeb802
to
709226d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage 90.03% 90.04%
=======================================
Files 13 13
Lines 3504 3505 +1
=======================================
+ Hits 3155 3156 +1
Misses 311 311
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a valid option for preseeding that u-i was not yet exposing, LGTM (I have a couple of minor nits though)
ubuntu-image.rst
Outdated
@@ -104,6 +105,15 @@ model_assertion | |||
both a revision and channel are provided, the revision specified will be | |||
installed in the image, and updates will come from the specified channel | |||
|
|||
--preseed | |||
Preseed the image (UC20 only). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be UC20+ only
debian/changelog
Outdated
|
||
[Masahiro Nakagawa] | ||
* Add sysfs-overlay option used with --presseed option. | ||
* This option is required to generate a preseeding image which enhances the initial boot time of Ubuntu Core 20. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is 20+, to be aligned with our preseeding documentation.
@upils I am sorry to bother you but I have one quick qestion about documentation-check.
Thank you in advance |
@masahiro-nakagawa everything is good on you end. This failure makes me notice the GH check is buggy. So do not worry about this one, I will fix it in another PR. The spread test check will also fail, that is expected. And thank you for adding the missing documentation on And feel free to set the PR "Ready for review" when you are done. So far I do not have any more comment than what @alfonsosanchezbeato spotted so I expect it to be merged quickly. |
52054f6
to
8249c03
Compare
… option (--sysfs-overlay=<path>) to ubuntu-image.rst
56d3b7e
to
21813d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a valid option we should support in ubuntu-image.
As picked by Alfonso, change 20
-> 20+
otherwise looks good.
LGTM
Rebased jawn-smith's PR