expose sysfs overlay option

[masahiro-nakagawa]

Rebased jawn-smith's PR

• Adds sysfs-overlay option to ubuntu-image.

[upils]

Hey @masahiro-nakagawa,

As mentionned here #120 (review), can you give us a bit of context of why you need this feature for?

@alfonsosanchezbeato @valentindavid Does it make sense to let users set this from the snapd point of view?

[masahiro-nakagawa]

This change allows to pass sysfs-overlay option required to generate a preseeding image which enhances the initial boot time of Ubuntu Core 20.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b223c38) 90.03% compared to head (21813d9) 90.04%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files          13       13           
  Lines        3504     3505    +1     
=======================================
+ Hits         3155     3156    +1     
  Misses        311      311           
  Partials       38       38           

Flag	Coverage Δ
unittests	90.04% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alfonsosanchezbeato]

This is a valid option for preseeding that u-i was not yet exposing, LGTM (I have a couple of minor nits though)

[alfonsosanchezbeato]

Maybe this should be UC20+ only

[alfonsosanchezbeato]

20+

[kubiko]

Agree this is 20+, to be aligned with our preseeding documentation.

[masahiro-nakagawa]

@upils I am sorry to bother you but I have one quick qestion about documentation-check.
I updated ubuntu-image.rst file but I still get below error. Would you please let me know if I need to modify other files to pass this test or not?

Run echo "Command line flags have been updated but the manpage has not"
Command line flags have been updated but the manpage has not
Error: Process completed with exit code 1.

Thank you in advance

[upils]

@masahiro-nakagawa everything is good on you end. This failure makes me notice the GH check is buggy. So do not worry about this one, I will fix it in another PR.

The spread test check will also fail, that is expected.

And thank you for adding the missing documentation on --preseed and --preseed-sign-key!

And feel free to set the PR "Ready for review" when you are done. So far I do not have any more comment than what @alfonsosanchezbeato spotted so I expect it to be merged quickly.

[kubiko]

This is a valid option we should support in ubuntu-image.
As picked by Alfonso, change 20 -> 20+ otherwise looks good.
LGTM