Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #176

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update dependencies #176

merged 3 commits into from
Jan 30, 2024

Conversation

upils
Copy link
Collaborator

@upils upils commented Jan 8, 2024

Update various dependencies, initially to solve a security issue in one of them.

@upils upils requested a review from sil2100 January 8, 2024 13:30
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c907b2) 90.03% compared to head (d0778ba) 90.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files          13       13           
  Lines        3504     3504           
=======================================
  Hits         3155     3155           
  Misses        311      311           
  Partials       38       38           
Flag Coverage Δ
unittests 90.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sil2100
sil2100 previously approved these changes Jan 10, 2024
Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, none of those seem particularly ominous. Should we also bump the snapcraft.yaml version before merging? (The +snapX version so people know this one has some actual changes). Please either merge as-is or bump the version and then merge. Thanks!

@upils
Copy link
Collaborator Author

upils commented Jan 10, 2024

This is failing to build with snapcraft. I only partially updated dependencies because canonical/snapd#13339 was not ready but since this should soon be merged, I will wait and use the last version of snapd to test everything is building properly.

@sil2100
Copy link
Collaborator

sil2100 commented Jan 30, 2024

Hey @upils ! Is this still blocked on the snapd PR that you mentioned?

@upils
Copy link
Collaborator Author

upils commented Jan 30, 2024

@sil2100 spread tests are failing (temporary unrelated failure) but otherwise this looks good. I now use the go snap instead of the package to use a more recent version without having to mess with PATH and to be coherent with our tests.

In the end the main goal of this PR (fix some vulnerabilities in our dependencies) is also reached.

@upils upils merged commit b223c38 into main Jan 30, 2024
11 of 13 checks passed
@upils upils deleted the update-dependencies branch January 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants