FR-5826 - Make sure we cleanup properly after update-grub

[upils]

No description provided.

[codecov]

Codecov Report

Merging #164 (58d8dfb) into main (8004b5a) will decrease coverage by 0.11%.
Report is 1 commits behind head on main.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   90.62%   90.52%   -0.11%     
==========================================
  Files          13       13              
  Lines        2636     2628       -8     
==========================================
- Hits         2389     2379      -10     
- Misses        215      216       +1     
- Partials       32       33       +1     

Files	Coverage Δ
internal/statemachine/helper.go	98.36% <94.44%> (-0.32%)	⬇️

[sil2100]

+1. I actually think that this way of testing this is very creative, so it's okay. I don't think stdout would be corrupted here somehow, so it's fine. Inline comment is more of a question comment, so feel free to merge it if you don't think it needs action.

[sil2100]

This is fine, +1, just made me think of something. Please note that I am not an experienced Go developer, so I'm fine if you say it's not the way to go. I was thinking: since the associateLoopDevice command basically attaches the loop device, one thing that comes to my mind would for the actual function to return the command that needs to be executed to 'clean up' when we're done. Not sure if that's a scheme that's frequent in Golang though. What do you think? This or having the detach bits as a separate helper function, so that people know that once you associate, you have to unassociate as well at some point.
Also, not very important, just overthinking things!

[upils]

I agree with you, I will do this. Moreover it will follow the same pattern used for the mount/unmount. It also makes sense to apply this to the dpkg-divert command I think.
I am not a golang expert either, but I think it looks fine to return a function to be called to cleanup things (using closure is rather idiomatic I think).