-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR-5759 - Use meta/gadget.yaml
for the gadget yaml path for classic
#159
Conversation
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 90.62% 90.52% -0.11%
==========================================
Files 13 13
Lines 2634 2606 -28
==========================================
- Hits 2387 2359 -28
Misses 215 215
Partials 32 32
|
d37b893
to
49055ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and as expected, but we also talked about improving the error wording in case meta/gadget.yaml
is missing after the gadget is built. I can't seem to find anything related to that here - is the error wording explanatory enough? Like, if someone builds an image with a gadget tree that doesn't install to meta/
, will they instantly know that the solution is to copy the file over to the directory? Since just an error of 'file missing' might make them a bit confused, as we have no explicit guidelines about what to install where.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.