Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-5759 - Use meta/gadget.yaml for the gadget yaml path for classic #159

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

upils
Copy link
Collaborator

@upils upils commented Oct 23, 2023

No description provided.

@upils upils requested a review from sil2100 October 24, 2023 06:19
@upils upils marked this pull request as ready for review October 24, 2023 06:19
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #159 (b110b11) into main (1865cb8) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head b110b11 differs from pull request most recent head 1828810. Consider uploading reports for the commit 1828810 to get more accurate results

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   90.62%   90.52%   -0.11%     
==========================================
  Files          13       13              
  Lines        2634     2606      -28     
==========================================
- Hits         2387     2359      -28     
  Misses        215      215              
  Partials       32       32              
Files Coverage Δ
internal/statemachine/classic_states.go 96.41% <100.00%> (-0.09%) ⬇️
internal/statemachine/common_states.go 99.10% <100.00%> (+<0.01%) ⬆️
internal/statemachine/pack_states.go 100.00% <100.00%> (ø)
internal/statemachine/snap_states.go 100.00% <100.00%> (ø)
internal/statemachine/state_machine.go 98.02% <ø> (ø)

... and 2 files with indirect coverage changes

Base automatically changed from invalid-fstab to main October 26, 2023 07:08
Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and as expected, but we also talked about improving the error wording in case meta/gadget.yaml is missing after the gadget is built. I can't seem to find anything related to that here - is the error wording explanatory enough? Like, if someone builds an image with a gadget tree that doesn't install to meta/, will they instantly know that the solution is to copy the file over to the directory? Since just an error of 'file missing' might make them a bit confused, as we have no explicit guidelines about what to install where.

Copy link
Collaborator

@sil2100 sil2100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sil2100 sil2100 merged commit ffca56b into main Oct 30, 2023
7 of 9 checks passed
@sil2100 sil2100 deleted the meta-gadget-yaml branch October 30, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants