FR-5403 - Pathname for manual customization not relative to image definition file #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 89.17% 90.44% +1.26%
==========================================
Files 11 11
Lines 2449 2449
==========================================
+ Hits 2184 2215 +31
+ Misses 244 208 -36
- Partials 21 26 +5
|
sil2100
approved these changes
Oct 6, 2023
| // Copy the file into the specified location in the chroot | ||
| dest := filepath.Join(targetDir, copyFile.Dest) | ||
| func manualCopyFile(customizations []*imagedefinition.CopyFile, confDefPath string, targetDir string, debug bool) error { | ||
| for _, c := range customizations { |
There was a problem hiding this comment.
Oh, looks much cleaner this way indeed!
…age_definition or model_assertion)
…andlers Other benefits: - removes usage of reflection in this function and handlers. - make it obvious when test cases are not handled
upils
force-pushed
the
path-relative-to-image-definition
branch
from
8762e99
to
5e2322d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.